#62: add option for specifying image#64
Merged
marcuspoehls merged 5 commits intosupercharge:mainfrom Jan 5, 2025
Merged
Conversation
Contributor
Author
|
@marcuspoehls please take a look at reviewing/merging this as I'm keen to pull images from ECR rather than Docker Hub |
Member
|
@Sam-Bate-ITV Hey Sam, thank you for your ping 🙂 I’ll review until tomorrow night |
Member
marcuspoehls
left a comment
marcuspoehls
left a comment
There was a problem hiding this comment.
@Sam-Bate-ITV Thank you for the pull request. I’ve added minor comments. Please have a look and maybe you find time to adjust the code? I would appreciate your help. Let’s push this feature over the finish line 🙂
Co-authored-by: Marcus Pöhls <marcus@futurestud.io>
|
Hope it will be merged 🙏 |
|
@Sam-Bate-ITV why Redis in Readme?) |
marcuspoehls
reviewed
Jan 5, 2025
Member
|
I’ve published version |
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to and solves issue #62
Adding a new optional field for
mongodb-imagewhich defaults to the original 'mongo'. This allows users to instead use an alternative image like 'public.ecr.aws/docker/library/mongo', avoiding the rate limits of Docker Hub.Note that in this PR I also set the tests to use the image from Amazon's docker repo so that all the tests can run without hitting rate limit of Docker Hub meaning all the tests ran within a few minutes.